Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): integrate withEventReplay() in provideClientHydration for new SSR apps #28469

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

alan-agius4
Copy link
Collaborator

Event Replay is now stable (see angular/angular#57895). This commit adds withEventReplay() to the provideClientHydration() call in newly created Angular applications with SSR.

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Sep 23, 2024
…lientHydration` for new SSR apps

Event Replay is now stable (see angular/angular#57895). This commit adds `withEventReplay()` to the `provideClientHydration()` call in newly created Angular applications with SSR.
Copy link

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-agius4 thanks for the help! 👍

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 23, 2024
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 23, 2024
@alan-agius4 alan-agius4 merged commit cfca544 into angular:main Sep 23, 2024
30 of 31 checks passed
@alan-agius4 alan-agius4 deleted the event-replay branch September 23, 2024 15:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants